Repository navigation
fix(design-data): point the second duplicate relationship at the mobile token - #1572
Merged
Merged
Conversation
added 2 commits
October 31, 2026 13:05
…le token 103 relationship records in 17 components referenced the desktop token twice, so the mobile token was never reachable through the relationship. The second record of each pair now references the token with the same name and the mobile scale.
🦋 Changeset detectedLatest commit: 71096ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
Run report for 71096fffTotal time: 2m 52s | Comparison time: 6m 41s | Estimated savings: 3m 49s (57.2% faster)
Expanded report
Changed files |
…e counterpart Two relationship records with the same scope, context and $ref where the token has a scale counterpart leave the other scale's token unreachable. The rule is a warning; the current data has none after the repoint, and it fires on the pre-fix text-area data.
…e-token' into fix/duplicate-relationship-mobile-token
This was referenced Oct 31, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
103 relationship records in 17 components referenced the desktop token twice, so the mobile token was never reachable through the relationship. The second record of each pair now references the token with the same name and the mobile scale.
Components: accordion, combo-box, date-picker, drop-zone, list-view, menu, number-field, picker, search-field, segmented-control, side-navigation, tag, tag-field, text-area, text-field, tooltip and tree-view.
Related Issue
Tracked in bead spectrum-design-data-p6ga.9 (split of #1569 into reviewable PRs). The data fix came out of visual rendering work, where the mobile bindings were unreachable.
Motivation and Context
To keep it from regressing, this PR also adds SPEC-072 (
relationship-duplicate-ref-scale-counterpart, a Layer 2 warning, cherry-picked from the visual recipes branch #1569): two relationship records with the same scope, context and$refwhere the token has a scale counterpart. It has a conformance fixture and a unit test. The current data has no such duplicates after the repoint, and the rule fires on the pre-fix text-area data. The rule ID is SPEC-072 so it matches #1569; IDs SPEC-060 to 071 arrive with that work.Changesets: a patch for
@adobe/spectrum-design-data(the data) and a patch for@adobe/design-data-specand@adobe/design-data-wasm(the rule). Changesets lists 10 packages becauseupdateInternalDependenciesispatchand these are workspace dependents of the data package: seven depend on it directly, and@adobe/spectrum-design-data-mcpandcomponent-options-editordepend on it through other workspace packages.fixedandlinkedare empty in.changeset/config.json.Without the fix, a mobile render or lookup through these relationships returns the desktop token. This is independent of the visual recipes work, so it goes to main now. It adds a patch changeset for
@adobe/spectrum-design-data.How Has This Been Tested?
Added
cargo test -p design-data-core(811 pass, including the SPEC-072 test),cargo clippy -D warningsandcargo fmt --check, andmoon run sdk:test sdk:codegen-check design-data:validate design-data:validate-datasetwith no SPEC-072 warnings on current data. Earlier:moon run design-data:validate design-data:legacy-output tokens:verifyLegacyOutput tokens:testpasses on a branch fromorigin/main, with no golden or legacy-output diffs. The SPEC-054 warnings indesign-data:validatewere already there (qkj5.55). Also ran the changeset linter with--fail-on-warnings,pnpm ai:check, and confirmedgit diff pnpm-lock.yamlis empty.Screenshots (if appropriate):
N/A
Types of changes
Checklist: